Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update environment variables from NMS to NGINX_AGENT #710

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Update environment variables from NMS to NGINX_AGENT #710

merged 2 commits into from
Jun 19, 2024

Conversation

spencerugbo
Copy link
Contributor

Proposed changes

Update the environment prefix seen in the documentation from NMS to NGINX_AGENT

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit a3ea575
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6670644581cc52000743b27b
😎 Deploy Preview https://deploy-preview-710--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ADubhlaoich
ADubhlaoich approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oCHRISo oCHRISo merged commit 8b9a5c4 into main Jun 19, 2024
31 checks passed
@oCHRISo oCHRISo deleted the change-env-variable-docs branch June 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliveromahony oliveromahony oliveromahony approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@aphralG aphralG aphralG approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@craigell craigell Awaiting requested review from craigell

@olli-holmala olli-holmala Awaiting requested review from olli-holmala

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spencerugbo @oliveromahony @ADubhlaoich @aphralG @oCHRISo