All committers have signed the CLA.

Ping ✨

@koenpunt Thanks for your patience. If you look at how we handled things like charset or http-equiv for meta tags, the API is taking in an html string that we map to React. Could we follow this same convention and put "class": "className" in the REACT_TAG_MAP?

REACT_TAG_MAP is for conversion the other way around, and looking up a property by its value isn't too efficient IMO.

Updated per request

All the other Helmet props take html keys in their objects, but htmlAttributes will be the only one that takes React keys, this could be confusing for people as the API doesn't match:

            <Helmet
                htmlAttributes={{"lang": "en", "amp": undefined, "className": "testclass"}}
                title="My Title"
                meta={[
                    {"charset": "utf-8"},
                    {"http-equiv": "content-type", "content": "text/html"}
                ]}
            />

All the other Helmet props take html keys in their objects

You got a point there. Makes me think that these html keys actually should've been React keys in the first place. Would you accept a PR to flip that, of course with deprecation warnings in place?

@koenpunt I'd rather not change the whole API for this one feature. If you could switch your solution to use REACT_TAG_MAP it would be the simplest.

Having just html keys seems more declarative to me because what you are putting in is exactly what you will get out. Because these keys are in an object and not passed directly to the component we aren't forced to use camel casing like React props. And if you are rendering on the server as a string you never have to do any conversion.

Because these keys are in an object and not passed directly to the component we aren't forced to use camel casing like React props.

Why is it that generateTagsAsString is using its own kind of templating instead of using renderToStaticMarkup? I know that renderToStaticMarkup is in react-dom/server, so obviously not to be (or even can't be) used on the client, but I don't believe the toString() of Helmet components is ought to to be used on the client?

@koenpunt excellent point, we have been meaning to convert the logic to use renderToStaticMarkup. Which would take React keys... although, we'll have to test out how this affects all the different tag types and we'll have to put in logic that satisfies cases like innerHTML and cssText.

We don't use the toString() method on the client. That's purely for the server.

@koenpunt Just merged a PR that is using itemprop as a key for title attributes. If you could flip this to convert class to className, I can pull this in. Thanks.

Updated, need me to squash some of these commits?

Also I expect people complaining about the inconsistency between class/className, but we'll see :)