[fix] null value for base tag prevents render #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndefined/null values for primary attributes of a tag) - this commit fixes the same issue for the base tag (as it uses a different function to calculate tag) Unit tests updated to cover undefined/null values for the whole API.
doctyper
reviewed
Nov 16, 2016
| <Helmet | ||
| script={[ | ||
| { | ||
| src: undefined, |
There was a problem hiding this comment.
Does this impact innerHTML support for script? Can you add a test for when src is undefined but innerHTML is defined?
There was a problem hiding this comment.
To your point, yes, this would not render a tag:
{
innerHTML: "function test() {console.log('test');} test();",
src: undefined
}
because it found a primary key without a value, BUT you should really never be specifying more than one primary key for your tag.
This, on the other hand, will render a tag because the for loop only uses one primary key, and takes the last one it finds:
{
src: undefined,
innerHTML: "function test() {console.log('test');} test();"
}
But again, this use case would be misuse.
doctyper
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of null values fix #165 - this commit fixes the same issue for the base tag (as it uses a different function to calculate tag)
Unit tests updated to cover undefined/null values for the whole API.