Add itemProp attributes for meta tag, titleAttributes for title #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 8, 2016 18:30
…tributes for meta to support SEO
|
|
Closed
|
When is this going to get merged? |
|
Is there a plan for this to be merged soon? |
|
Thanks for the PR and your patience. I will actively work on getting this into the codebase asap. |
cwelch5
reviewed
Dec 4, 2016
| @@ -273,6 +295,10 @@ const generateTagsAsString = (type, tags) => { | |||
| } | |||
|
|
|||
| const encodedValue = encodeSpecialCharacters(tag[attribute]); | |||
| // itemProp in react is camelcase, but will generate as lowercase | |||
There was a problem hiding this comment.
API should be html key itemprop as you would expect to see it in the DOM. It will just pass-through in this function.
| Object.keys(attributes).forEach((attribute) => { | ||
| props[attribute] = attributes[attribute]; | ||
| }); | ||
|
|
There was a problem hiding this comment.
You would do a conversion here using REACT_TAG_MAP to convert itemprop to itemProp
| @@ -368,6 +399,7 @@ const Helmet = (Component) => { | |||
| * @param {String} title: "Title" | |||
| * @param {String} defaultTitle: "Default Title" | |||
| * @param {String} titleTemplate: "MySite.com - %s" | |||
| * @param {Object} titleAttributes: {"itemProp": "name"} | |||
|
@cwelch5 Updated. |
|
Thx @dattran92 for your patience. Will publish soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting issue #113.
Usage:
<Helmet meta={[{'itemProp': 'image', 'content': 'some_url_here'}]} /><Helmet title="Your title" titleAttributes={{itemProp: 'name'}} />