handle null values for tags (and fix eslinting error) #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the primaryAttributeKey's value is null, then we ignore that entire tag. This is mostly useful for programmatic definitions of tag values where the data store may not be fully defined. This resolves #162.
For instance (and exemplified in test code), if an icon is being described, but
null
is provided in thehref
, the tag will not be added.I also fixed an eslint error on
src/Helmet.js
ln 24.