Dev > Master #58
Merged
Dev > Master #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create TEMPLATE branch for automated syncing
Create TEMPLATE branch for automated syncing
Bump version to 1.0.1dev
Create an empty channel for blacklist when params.blacklist is false.
Use staged blacklist file in makeGenomeFilter
Allocate more RAM to the process running MACS2
Update markdownlint checks
Bump version to 1.1.0
|
Thanks @maxulysse !! Just need one more approval on this and we are ready to go |
apeltzer
approved these changes
Nov 4, 2019
CHANGELOG.md
Outdated
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | ||
| and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [1.1.0] - 2019-11-01 |
There was a problem hiding this comment.
Suggested change
| ## [1.1.0] - 2019-11-01 | |
| ## [1.1.0] - 2019-11-05 |
Maybe 5th?
There was a problem hiding this comment.
Ah, that's been changed in the open PR to dev 👍
There was a problem hiding this comment.
I'll merge that last minute before the merge to master
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ####################################################################### | |||
| ####################################################################### | |||
There was a problem hiding this comment.
I think I'll get this going for Eager soon too 👍 Looks fab :-)
There was a problem hiding this comment.
Thanks. It does work really well, restricts user error and gives you experiment-level info 😃
Address comments for PR #58 (Dev > Master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to nf-core/atacseq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/atacseq/tree/master/.github/CONTRIBUTING.md