Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev > Master for v1.0.0 release #29

Merged
merged 22 commits into from
Apr 9, 2019
Merged

Dev > Master for v1.0.0 release #29

merged 22 commits into from
Apr 9, 2019

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented Apr 8, 2019

No description provided.

@drpatelh
Copy link
Member Author

drpatelh commented Apr 8, 2019

@ewels @apeltzer These are all failing due to the conda lint issues with tools v1.5.

Not sure whether its worth doing a release in the current climate? Or we could re-trigger the tests when tools v1.6 is released. However, I dont know if there are any downsides to that.

On the plus side, its another mammoth set of changes for you to review on a Monday afternoon.

@drpatelh
Copy link
Member Author

drpatelh commented Apr 8, 2019

@sven1103 Has promised he wont sleep until he creates a new release of tools tonight.

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all great - well, didn't expect anything to happen after all the reviews until now 👍

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - merge this :-)

@apeltzer apeltzer merged commit c65bf6c into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants