Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 patch release to fix Conda environment and enable DSL1 in the nextflow.config #177

Merged
merged 7 commits into from
May 12, 2022

Conversation

JoseEspinosa
Copy link
Member

nf-core/atacseq pull request

Many thanks for contributing to nf-core/atacseq!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@JoseEspinosa JoseEspinosa changed the title Patch 1.2.2 patch release to fix Conda environment and enable DSL1 in the nextflow.config May 11, 2022
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

CI is a mess because it's super old versions of the CI. We can ignore as this is for a patch release.

Comment on lines +8 to +9
* Minor patch release to fix Conda environment and enable DSL1 by default in the `nextflow.config`.
### `Dependencies`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Minor patch release to fix Conda environment and enable DSL1 by default in the `nextflow.config`.
### `Dependencies`
* Minor patch release to fix Conda environment and enable DSL1 by default in the `nextflow.config`.
### `Dependencies`

@ewels ewels merged commit aadf1a2 into master May 12, 2022
@JoseEspinosa JoseEspinosa deleted the patch branch May 12, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants