Update aws test GitHub Actions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpatelh
reviewed
Jun 30, 2020
| AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}} | ||
| AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}} | ||
| TOWER_ACCESS_TOKEN: ${{secrets.AWS_TOWER_TOKEN}} | ||
| #AWS_JOB_DEFINITION: ${{secrets.AWS_JOB_DEFINITION}} |
There was a problem hiding this comment.
Why is this commented out @ggabernet?
drpatelh
reviewed
Jun 30, 2020
| --region eu-west-1 \ | ||
| --job-name nf-core-atacseq \ | ||
| --job-queue $AWS_JOB_QUEUE \ | ||
| --job-definition nextflow-4GiB \ |
There was a problem hiding this comment.
We may not need this larger instance and the garbage collection (-XX:+UseG1GC) after we have implemented Paolo's config trick.
There was a problem hiding this comment.
Hi yes, that is right, but this is not yet implemented in the awsbatch.config. That's the same reason why the env variable $AWS_JOB_DEFINITION is commented out above.
drpatelh
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to contributing to nf-core/atacseq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/atacseq/tree/master/.github/CONTRIBUTING.md