Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guest name color in light color themings #321

Merged
merged 1 commit into from
May 22, 2017
Merged

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented May 19, 2017

Guest name color in light color themings is black.
screen shot 2017-05-19 at 12 07 20
When the guest is in a call the top bar becomes transparent and the name is not visible anymore.

Now (in-call):
screen shot 2017-05-19 at 12 08 05

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@jancborchardt
Copy link
Member

Good stuff 👍

@codecov
Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #321 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #321   +/-   ##
=========================================
  Coverage     15.46%   15.46%           
  Complexity      274      274           
=========================================
  Files            18       18           
  Lines          1293     1293           
=========================================
  Hits            200      200           
  Misses         1093     1093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fdb0f...0de1935. Read the comment docs.

@nickvergessen nickvergessen merged commit 9be135c into master May 22, 2017
@nickvergessen nickvergessen deleted the guest-name branch May 22, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants