Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE servers configuration #295

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Fix ICE servers configuration #295

merged 2 commits into from
Apr 21, 2017

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Apr 20, 2017

  • Fix problem with 'stunservers' and 'turnservers' events:
    Sometimes 'stunservers' event is received after 'turnservers' event.
    This causes that only the STUN server is set as ICE servers (TURN servers are overwritten).

  • Also remove Google's default STUN server

Ivansss added 2 commits April 20, 2017 19:01
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #295   +/-   ##
=========================================
  Coverage     15.79%   15.79%           
  Complexity      266      266           
=========================================
  Files            17       17           
  Lines          1266     1266           
=========================================
  Hits            200      200           
  Misses         1066     1066

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf0b626...4df1ebc. Read the comment docs.

@nickvergessen nickvergessen merged commit 89a5f1d into master Apr 21, 2017
@nickvergessen nickvergessen deleted the stun-turn-config branch April 21, 2017 06:54
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants