Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance mnemonic on dark mode #7001

Merged
merged 1 commit into from
Sep 25, 2020
Merged

enhance mnemonic on dark mode #7001

merged 1 commit into from
Sep 25, 2020

Conversation

tobiasKaminsky
Copy link
Member

Fix #6700

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

imageimage

AndyScherzinger
AndyScherzinger approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Grey 200 value should be in the default colors not the night version.

Other than that, looks good to me.

I would have expected the font color inverse colors to be present already thought...? Can't check this on mobile 😔

@tobiasKaminsky
Copy link
Member Author

I would have expected the font color inverse colors to be present already thought...? Can't check this on mobile pensive

No idea, why they do not change.
As the title already changes the color depending on dark/light.

@tobiasKaminsky
enhance mnemonic on dark mode
a29739c 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15944.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

stable-light-blue-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

stable-light-blue-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15944-Screenshot-stable-light-blue

@nextcloud-android-bot
Copy link
Collaborator

master-light-blue-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

master-light-blue-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15944-Screenshot-master-light-blue

@nextcloud-android-bot
Copy link
Collaborator

Codacy

393

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total319

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total319

@tobiasKaminsky tobiasKaminsky merged commit b5f7549 into master Sep 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the mnemonic branch September 25, 2020 08:51
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.14.0 milestone Sep 25, 2020
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
@tobiasKaminsky
Merge pull request nextcloud#7001 from nextcloud/mnemonic
a461ff3 
enhance mnemonic on dark mode
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.14.0
Development

Successfully merging this pull request may close these issues.

Dark mode: 12-digit mnemonic code creation dialog
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger