Update DocumentsProvider roots when enabling/disabling app lock feature #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torsten Grote <t@grobox.de>
grote
force-pushed
the
6882-passcode-update-roots
branch
from
5fb9084 to
f7e711d
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15910.apk |
12 tasks
Codacy393Lint
SpotBugs (new)
SpotBugs (master)
|
tobiasKaminsky
approved these changes
Sep 23, 2020
thelittlefireman
pushed a commit
to thelittlefireman/android
that referenced
this pull request
Mar 19, 2021
…-roots Update DocumentsProvider roots when enabling/disabling app lock feature Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't attempt to re-enable the roots when the passcode was entered. As the timeout is only 5 seconds that would not be very useful. Also, you would need extra infrastructure to disable the roots again from the background after 5 seconds which might not be reliable (if the OS kills you before). So keeping the roots off when the passcode feature is active is probably the sanest approach.
Fixes #6882