NVSHAS-9584: Update tar.go with using upstream package tarutil #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kyledong-suse
commented
Dec 19, 2024
•
kyledong-suse
commented
- Remove unmaintained functions in tar.go
- Import upstream package tarutil in tar.go
- Add upstream package tarutil in vendor
kyledong-suse
requested review from
yasker,
a team,
holyspectral and
BinX-Suse
as code owners
holyspectral
reviewed
Jan 9, 2025
| func (s *ScanUtil) readRunningPackages(id string, pid int, prefix, kernel string, pidHost bool) ([]utils.TarFileInfo, bool) { | ||
| var files []utils.TarFileInfo | ||
| func (s *ScanUtil) readRunningPackages(pid int, prefix, kernel string, pidHost bool) (tarutil.FilesMap, bool) { | ||
| files := make(tarutil.FilesMap) |
There was a problem hiding this comment.
tarutil.FilesMap is just type FilesMap map[string][]byte
Do we need github.com/coreos/clair/pkg/tarutil for it?
There was a problem hiding this comment.
I agree that we don't need github.com/coreos/clair/pkg/tarutil. I'll create type FilesMap map[string][]byte for tar processing
There was a problem hiding this comment.
After discussed with Jay, I aware that scanner uses most of the tar functions. So it's better to keep this tar.go and update it with using the upstream tarutil.
There was a problem hiding this comment.
There seems to be some confusion here. Let's talk through this.
kyledong-suse
force-pushed
the
main
branch
2 times, most recently
from
77fc23e to
45dd755
Compare
kyledong-suse
changed the title
kyledong-suse
force-pushed
the
main
branch
3 times, most recently
from
6b026fb to
ed21821
Compare
kyledong-suse
changed the title
1. Remove unmaintained functions in tar.go 2. Import upstream package tarutil in tar.go 3. Add upstream package tarutil in vendor Remove tarutil, create type FilesMap map[string][]byte instead Update tar.go with using upstream package tarutil
holyspectral
requested changes
Jan 17, 2025
1. Remove unmaintained tar.go 2. Add upstream package github.com/coreos/clair in vendor 3. Create extract.go for NV implemented tar realted functions
|
Need to separate this PR into 2 part,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.