Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #586 FormData.FormValue cannot be handled by Jackson JSON parser #587

Merged
merged 3 commits into from
Jul 23, 2019
Merged

fixes #586 FormData.FormValue cannot be handled by Jackson JSON parser #587

merged 3 commits into from
Jul 23, 2019

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Jul 19, 2019

No description provided.

@stevehu stevehu requested review from BalloonWen and DSchrupert July 22, 2019 20:27
jefperito
jefperito reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@jefperito jefperito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need comment? i think code should express your intent

@stevehu
Copy link
Contributor Author

stevehu commented Jul 23, 2019

In most of the cases, we don't need the comment like this; however, this bug was escaped from our code review before due to the special data structure and interaction with the Jackson. I think the comment will help us to pay more attention to the detail in other cases. Also, it lets other developers know why we have made the change.

@stevehu stevehu added 1.6.x Merge to 1.6.x Branch 2.0.x Merge to 2.0.x Branch labels Jul 23, 2019
@stevehu stevehu merged commit 99f9a64 into master Jul 23, 2019
@stevehu stevehu deleted the issue586 branch July 23, 2019 15:02
stevehu added a commit that referenced this pull request Jul 23, 2019
@stevehu
fixes #586 FormData.FormValue cannot be handled by Jackson JSON parser (
f0abcb0 
#587)

* fixes #586 FormData.FormValue cannot be handled by Jackson JSON parser

* fixes #586 update the format based on the code review
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
@stevehu
fixes networknt#586 FormData.FormValue cannot be handled by Jackson J…
4640a27 
…SON parser (networknt#587)

* fixes networknt#586 FormData.FormValue cannot be handled by Jackson JSON parser

* fixes networknt#586 update the format based on the code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefperito jefperito jefperito left review comments

@jiachen1120 jiachen1120 jiachen1120 approved these changes

@BalloonWen BalloonWen BalloonWen approved these changes

@lanphan lanphan Awaiting requested review from lanphan

@DSchrupert DSchrupert Awaiting requested review from DSchrupert

Assignees
No one assigned
Labels
1.6.x Merge to 1.6.x Branch 2.0.x Merge to 2.0.x Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevehu @jefperito @BalloonWen @jiachen1120