Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #445 update client module to access signing service #446

Merged
merged 1 commit into from
Apr 1, 2019
Merged

fixes #445 update client module to access signing service #446

merged 1 commit into from
Apr 1, 2019

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Apr 1, 2019

No description provided.

@stevehu stevehu mentioned this pull request Apr 1, 2019
Merged
@codecov-io
Copy link

codecov-io commented Apr 1, 2019 •
edited
Loading

Codecov Report

Merging #446 into master will decrease coverage by 0.45%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #446      +/-   ##
===========================================
- Coverage     49.56%   49.1%   -0.46%     
  Complexity     1680    1680              
===========================================
  Files           241     242       +1     
  Lines         10464   10560      +96     
  Branches       1503    1509       +6     
===========================================
  Hits           5186    5186              
- Misses         4662    4758      +96     
  Partials        616     616
Impacted Files Coverage Δ Complexity Δ
...n/java/com/networknt/client/oauth/OauthHelper.java 33.11% <0%> (-6.2%) 20 <0> (ø)
...n/java/com/networknt/client/oauth/SignRequest.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc4f7d...c5fc92d. Read the comment docs.

@stevehu
Copy link
Contributor Author

stevehu commented Apr 1, 2019

Document update can be found in networknt/light-doc#60

@stevehu stevehu merged commit b172df1 into master Apr 1, 2019
@stevehu stevehu deleted the issue445 branch April 1, 2019 14:07
@stevehu stevehu mentioned this pull request Apr 9, 2019
Closed
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
@stevehu
fixes networknt#445 update client module to access signing service (n…
52df480 
…etworknt#446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddobrin ddobrin ddobrin approved these changes

@BalloonWen BalloonWen Awaiting requested review from BalloonWen

@jiachen1120 jiachen1120 Awaiting requested review from jiachen1120

@DSchrupert DSchrupert Awaiting requested review from DSchrupert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevehu @codecov-io @ddobrin