Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #421 add last handler to Handler class for handler chain inject… #422

Merged
merged 1 commit into from
Mar 6, 2019
Merged

fixes #421 add last handler to Handler class for handler chain inject… #422

merged 1 commit into from
Mar 6, 2019

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Mar 6, 2019

… in the beginning

@stevehu stevehu requested review from ddobrin and DSchrupert March 6, 2019 01:34
@codecov-io
Copy link

codecov-io commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #422 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #422      +/-   ##
=============================================
- Coverage      49.51%   49.49%   -0.02%     
- Complexity      1649     1650       +1     
=============================================
  Files            240      240              
  Lines          10424    10432       +8     
  Branches        1497     1498       +1     
=============================================
+ Hits            5161     5163       +2     
- Misses          4646     4653       +7     
+ Partials         617      616       -1
Impacted Files Coverage Δ Complexity Δ
...va/com/networknt/handler/OrchestrationHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...r/src/main/java/com/networknt/handler/Handler.java 41.7% <0%> (-0.86%) 23 <0> (ø)
.../src/main/java/com/networknt/utility/HashUtil.java 63.33% <0%> (+3.33%) 11% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60c9b2...bc744f4. Read the comment docs.

@DSchrupert
Copy link
Member

#421

@stevehu stevehu merged commit 040923a into develop Mar 6, 2019
@stevehu stevehu deleted the issue421 branch March 6, 2019 14:48
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
@stevehu
fixes networknt#421 add last handler to Handler class for handler cha…
8d7281b 
…in inject in the beginning (networknt#422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddobrin ddobrin ddobrin approved these changes

@DSchrupert DSchrupert DSchrupert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevehu @codecov-io @DSchrupert @ddobrin