fixes #316 update resource and handler to support SPA from handler.yml #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For detailed configuration in the light-router, please take a look at this checkin. networknt/light-config-test#71 |
|
Looks good. Thanks |
GavinChenYan
approved these changes
Nov 3, 2018
ddobrin
reviewed
Nov 3, 2018
|
The current PathHandler will return 404 error code only if there is no resource found for the path specified. I am not sure if we should customize it to return a status instead with an additional description like a real API response. |
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
fixes networknt#316 update resource and handler to support SPA from handler.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.