Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

chore: add test for node: prefix #698

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Oct 4, 2021

Adds a test asserting that we can handle imports with the node: prefix.

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

⏱ Benchmark results

largeDepsEsbuild: 11.1s

^  11.1s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 11.1s

largeDepsZisi: 1m 0.7s

^ 1m 0.7s 
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    
Legend
  • T (current commit): 1m 0.7s

@eduardoboucas eduardoboucas changed the title fix: allow built-in modules to be required using the node: prefix chore: add test for node: prefix Nov 8, 2021
@eduardoboucas eduardoboucas force-pushed the fix/node-force-builtin branch from a6d3da9 to dbf7fd5 Compare November 8, 2021 11:23
@eduardoboucas eduardoboucas marked this pull request as ready for review November 8, 2021 11:25
@eduardoboucas eduardoboucas merged commit 6cc2b3a into main Nov 8, 2021
@eduardoboucas eduardoboucas deleted the fix/node-force-builtin branch November 8, 2021 11:45
Copy link
Contributor

@netlify-team-account-1 netlify-team-account-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking back my approval here - are we sure that we don't need to change package.json? If this package is installed by netlify/build, it won't take the package-lock into account, and potentially install precinct@8.0 or precinct@8.1.

netlify-team-account-1 added a commit that referenced this pull request Nov 8, 2021
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
* chore: add failing test

* chore: update package.json precinct to 8.2, too

consumers of this package should use ^8.2!

* chore: update test to reflect stream/web problems

* chore: adapt fixture to streams

* Update main.js

* Update main.js

* chore: revert change to `package.json`

Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Netlify Team Account 1 <90322326+netlify-team-account-1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants