chore: replace removeFalsy with the more idiomatic removeUndefined (#756

) context: #753 (comment) Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
netlify · Oct 21, 2021 · 4167cfc · 4167cfc · github-actions · Oct 21, 2021
1 parent 776545e
commit 4167cfc
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 17 deletions.
diff --git a/src/utils/format_result.ts b/src/utils/format_result.ts
@@ -1,15 +1,18 @@
 import { FunctionArchive } from '../function'
 import { RuntimeName } from '../runtimes/runtime'
 
-import { removeFalsy } from './remove_falsy'
+import { removeUndefined } from './remove_undefined'
 
-type FunctionResult = FunctionArchive & { runtime: RuntimeName }
+type FunctionResult = Omit<FunctionArchive, 'runtime'> & { runtime: RuntimeName }
 
 // Takes the result of zipping a function and formats it for output.
 const formatZipResult = (archive: FunctionArchive) => {
-  const result = removeFalsy({ ...archive, runtime: archive.runtime.name }) as FunctionResult
+  const functionResult: FunctionResult = {
+    ...archive,
+    runtime: archive.runtime.name,
+  }
 
-  return result
+  return removeUndefined(functionResult)
 }
 
 export { formatZipResult }

diff --git a/src/utils/remove_falsy.ts b/src/utils/remove_falsy.ts
diff --git a/src/utils/remove_undefined.ts b/src/utils/remove_undefined.ts
@@ -0,0 +1,7 @@
+import filterObj from 'filter-obj'
+
+const removeUndefined = function <T>(obj: T): T {
+  return filterObj(obj, (key, value) => value !== undefined) as T
+}
+
+export { removeUndefined }