Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: display "typeCheck / SWC" info message only when relevant #2791

Closed
1 task done
gterras opened this issue Oct 21, 2024 · 2 comments
Closed
1 task done

CLI: display "typeCheck / SWC" info message only when relevant #2791

gterras opened this issue Oct 21, 2024 · 2 comments

Comments

@gterras
Copy link

gterras commented Oct 21, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Having SWC set as per the docs, and using --type-check flag, an info message will be displayed:

"typeCheck" will not have any effect when "builder" is not "swc".

image

This message seems to be only useful when actually not using SWC, in any other case it's a bit confusing since it tends to bring the question "wait is SWC actually enabled here?" every time this is ran. It also adds a bit of clogging.

Describe the solution you'd like

Do not display the message if SWC is actually the selected builder (could then also be turned into a warning).

Teachability, documentation, adoption, migration strategy

ced1ca60-8ab2-41b2-8516-de994cf3e699

What is the motivation / use case for changing the behavior?

QOL

@kamilmysliwiec kamilmysliwiec transferred this issue from nestjs/nest Nov 5, 2024
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Nov 6, 2024

Let's track this here #2792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants