feat(websockets): global guards are called in websocket too #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can add an option to enable or disable the global config for the WebSocketModule. Because if we do not add it, then we can break someone's application. |
I add this options. And this PR not break other projects. If you want to use global pipes,interceptors, guards for gateways, you should call app.applyApplicationConfigToWs(); |
Maligosus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #11461
What is the new behavior?
Global guards are called too in @nestjs/websockets. It's optional and don't called, if we don't enable globalGuards for websocket.
Resolve #11461
Does this PR introduce a breaking change?
Other information