Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add partial update ability. #55

Merged
merged 3 commits into from
May 18, 2016
Merged

feature: add partial update ability. #55

merged 3 commits into from
May 18, 2016

Conversation

1e1
Copy link
Contributor

@1e1 1e1 commented Oct 22, 2014

usage like indexing:

                $params = array(
                    '_refresh_' => false,
                    'index'     => $update->indice,
                    'type'      => $update->type,
                );

                $es->update($update->document, $id, $params);

You can create a document then update just its state.

feature: add partial update ability.
ced0ddd 
usage like indexing:

                $params = array(
                    '_refresh_' => false,
                    'index'     => $update->indice,
                    'type'      => $update->type,
                );

                $es->update($update->document, $id, $params);
@nervetattoo
Copy link
Owner

This makes sense. Please add tests (and fix broken travis build) as well as add documentation for this, then I'll merge it asap.

@1e1
Copy link
Contributor Author

1e1 commented Dec 15, 2014

Sorry I can read the Travis log (PHP 5.3: OK, PHP 5.4: 8 exceptions).
But I can't find the atoum tests.
And first exceptions seem thrown from "old" functions, like it were no teardown from the first tests (5.3).

Can you help me? :/

@nervetattoo
Copy link
Owner

Seems the failing test happened due to timeout being reached. Triggered a rerun of the test and they all passed. I still want to see this added to the docs and preferably test cases added as well.
The tests themselves are under tests/units/* and you can run them by first doing a composer install and then just running ./runtests.sh, or manually running the atoum command.

Aymeric GERLIER added 2 commits December 15, 2014 14:14
feature: add partial update ability.
ab272c9 
usage like indexing:

                $params = array(
                    '_refresh_' => false,
                    'index'     => $update->indice,
                    'type'      => $update->type,
                );

                $es->update($update->document, $id, $params);
Merge branch 'develop_update' of https://github.com/1e1/elasticsearch …
8ac131e 
…into develop_update
@1e1
Copy link
Contributor Author

1e1 commented Dec 15, 2014

UT pushed

@nervetattoo
Copy link
Owner

Do you mind adding a paragraph in the readme @1e1 so we can get this merged?

@nervetattoo nervetattoo merged commit cb734b7 into nervetattoo:master May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1e1 @nervetattoo