feat(jobs): jobstart(…,{term=true}), deprecate termopen() #31343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
force-pushed
the
jobstart
branch
2 times, most recently
from
f3eacad to
4c346f6
Compare
11 tasks
Problem: `termopen` has long been a superficial wrapper around `jobstart`, and has no real purpose. Also, `vim.system` and `nvim_open_term` presumably will replace all features of `jobstart` and `termopen`, so centralizing the logic will help with that. Solution: - Introduce "term" flag of `jobstart`. - Deprecate `termopen`.
justinmk
changed the title
zeertzjq
reviewed
Dec 20, 2024
| @@ -20,8 +20,8 @@ There are several ways to open a channel: | |||
|
|
|||
| 2. Through stdin, stdout and stderr of a process spawned by |jobstart()|. | |||
|
|
|||
| 3. Through the PTY master end of a PTY opened with | |||
| `jobstart(..., {'pty': v:true})` or |termopen()|. | |||
| 3. Through the PTY master end of a PTY opened with |nvim_open_term()| or | |||
There was a problem hiding this comment.
nvim_open_term() does not open a PTY.
There was a problem hiding this comment.
Thanks, fixed in #31479
mikavilpas
added a commit
to mikavilpas/yazi.nvim
that referenced
this pull request
Dec 20, 2024
This was deprecated on neovim nightly yesterday, and will probably be removed in the future. This should have no effect on the user. neovim/neovim#31343
towry
pushed a commit
to pze/neovim
that referenced
this pull request
Dec 31, 2024
Problem: `termopen` has long been a superficial wrapper around `jobstart`, and has no real purpose. Also, `vim.system` and `nvim_open_term` presumably will replace all features of `jobstart` and `termopen`, so centralizing the logic will help with that. Solution: - Introduce `eval/deprecated.c`, where all deprecated eval funcs will live. - Introduce "term" flag of `jobstart`. - Deprecate `termopen`.
mikavilpas
added a commit
to mikavilpas/yazi.nvim
that referenced
this pull request
Jan 6, 2025
mikavilpas
added a commit
to mikavilpas/yazi.nvim
that referenced
this pull request
Jan 6, 2025
mikavilpas
added a commit
to mikavilpas/yazi.nvim
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
termopenhas long been a superficial wrapper aroundjobstart, and has no real purpose. Also,vim.systemandnvim_open_termpresumably will replace all features ofjobstartandtermopen, so centralizing the logic will help with that. cc @lewis6991From #5485 :
Solution
eval/deprecated.c, where all deprecated eval funcs will live.jobstart.termopen.