Metrics review #13
Merged
Metrics review #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoalmeida94
approved these changes
Sep 25, 2020
| """ | ||
| Structural SIMularity index | ||
| """ | ||
| _assert_image_shapes_equal(org_img, pred_img, "SSIM") | ||
|
|
||
| return structural_similarity(org_img, pred_img, data_range=data_range, multichannel=True) | ||
| return structural_similarity(org_img, pred_img, data_range=max_p, multichannel=True) | ||
|
|
||
|
|
||
| def sliding_window(image, stepSize, windowSize): |
There was a problem hiding this comment.
The question of the processing time,
- should we make the step size and window size exposed in the parameters? Just in case we want to speed it up
There was a problem hiding this comment.
Good idea. Did that.
BTW, it might now be faster as the compute-intensive operations only have to consider one band and not all of them.
Comment on lines
+251
to
+252
| # The original paper states that SAM values are expressed as radians, while e.g. Lanares | ||
| # et al. (2018) use degrees. We therefore made this configurable, with degree the default |
Comment on lines
+5
to
+12
| * <i><a href="https://en.wikipedia.org/wiki/Root-mean-square_deviation">Root mean square error (RMSE)</a></i>, | ||
| * <i><a href="https://en.wikipedia.org/wiki/Peak_signal-to-noise_ratio">Peak signal-to-noise ratio (PSNR)</a></i>, | ||
| * <i><a href="https://en.wikipedia.org/wiki/Structural_similarity">Structural Similarity Index (SSIM)</a></i>, | ||
| * <i><a href="https://www4.comp.polyu.edu.hk/~cslzhang/IQA/TIP_IQA_FSIM.pdf">Feature-based similarity index (FSIM)</a></i>, | ||
| * <i><a href="https://www.tandfonline.com/doi/full/10.1080/22797254.2019.1628617">Information theoretic-based Statistic Similarity Measure (ISSM)</a></i>, | ||
| * <i><a href="https://www.sciencedirect.com/science/article/abs/pii/S0924271618302636">Signal to reconstruction error ratio (SRE)</a></i>, | ||
| * <i><a href="https://ntrs.nasa.gov/citations/19940012238">Spectral angle mapper (SAM)</a></i>, and | ||
| * <i><a href="https://ece.uwaterloo.ca/~z70wang/publications/quality_2c.pdf">Universal image quality index (UIQ)</a></i> |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking each of the metrics so we have peace of mind that these implementations are 100% correct or at least ambiguities are documented.
All values are reasonable now with the exception of UIQ which dropped by about 50 %. Can you please have a thorough look if I introduced an error there?