Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Update naj to v4.0.3 #1135

Merged
merged 3 commits into from
Jul 19, 2024
Merged

perf: Update naj to v4.0.3 #1135

merged 3 commits into from
Jul 19, 2024

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Jul 18, 2024 •
edited
Loading

Description

Package Name Current Package Size (K) Improved Package Size (K)
account-export 472 404
bitget-wallet 188 160
bitte-wallet 20 20
coin98-wallet 120 88
core 648 556
here-wallet 140 108
ledger 220 144
math-wallet 288 232
meteor-wallet 172 144
mintbase-wallet 20 20
modal-ui 532 476
modal-ui-js 468 412
my-near-wallet 436 372
narwallets 240 200
near-mobile-wallet 188 156
near-snap 116 92
nearfi 84 84
neth 140 140
nightly 200 168
okx-wallet 100 76
ramper-wallet 80 80
sender 312 256
wallet-connect 344 264
wallet-utils 208 168
welldone-wallet 344 256
xdefi 108 76
Total 6.0M 5.0M

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

gtsonevv and others added 2 commits July 18, 2024 10:53
@gtsonevv
update NAJ to v4
13eb90a
@gtsonevv
[feature] - Update naj versions to v4.0.3
01c8d9e 
  - Use Yarn Workspaces with NX to manage multiple versions of npm packages across the monorepo
  - Configured root package.json for Yarn Workspaces
  - Updated tsconfig.base.json with necessary path mappings
  - Adjusted individual package tsconfig.json files to extend the base configuration
  - Ensured consistent dependency management across packages
  - Resolved type conflicts and build issues by aligning TypeScript configurations
  - locked down versions of dependencies to ensure consistent builds
@gtsonevv gtsonevv requested a review from pivanov July 18, 2024 07:56
@github-actions github-actions bot changed the title Update naj to v4.0.3 perf: Update naj to v4.0.3 Jul 18, 2024
@pivanov pivanov requested a review from trechriron July 18, 2024 08:00
pivanov
pivanov previously approved these changes Jul 18, 2024
View reviewed changes
@pivanov pivanov self-requested a review July 18, 2024 09:38
pivanov
pivanov approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

frol
frol approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great quick win!

It looks good to me

@gtsonevv gtsonevv mentioned this pull request Jul 18, 2024
Closed
4 tasks
@pivanov pivanov merged commit 75b449b into near:dev Jul 19, 2024
7 checks passed
@pivanov pivanov mentioned this pull request Jul 19, 2024
Closed
@pivanov pivanov deleted the update-naj-to-v4.0.3 branch July 19, 2024 05:35
@pivanov pivanov mentioned this pull request Jul 19, 2024
Closed
@trechriron trechriron mentioned this pull request Jul 24, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@pivanov pivanov pivanov approved these changes

@trechriron trechriron Awaiting requested review from trechriron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsonevv @pivanov @frol