Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix react sample startup guide & add needful dependency … #1128

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

docs: fix react sample startup guide & add needful dependency … #1128

wants to merge 6 commits into from

Conversation

AlienegraGeek
Copy link

@AlienegraGeek AlienegraGeek commented Jul 3, 2024 •
edited
Loading

Description

Refined the guidance for example and added a required dependency that otherwise would have prevented the sample service from starting due to dependency and build issues.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@trechriron trechriron requested review from trechriron and hcho112 and removed request for trechriron July 15, 2024 22:12
trechriron
trechriron requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@trechriron trechriron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the initial branch merge to DEV. Thanks!

@trechriron
Update CONTRIBUTING.md
f3c008c
@trechriron
Add images for contributing.md file.
be9e35d
@trechriron
Update CONTRIBUTING.md
c89b6b1 
Added images to the Submitting a PR section. Uploaded images in a separate commit.
@AlienegraGeek AlienegraGeek changed the base branch from main to dev July 16, 2024 08:05
@github-actions github-actions bot changed the title docs(react): fix react sample startup guide & add needful dependency … docs: fix react sample startup guide & add needful dependency … Jul 16, 2024
@AlienegraGeek
Copy link
Author

AlienegraGeek commented Jul 16, 2024 •
edited
Loading

Please change the initial branch merge to DEV. Thanks!

Done.

@AlienegraGeek AlienegraGeek requested a review from trechriron July 16, 2024 08:06
trechriron
trechriron previously approved these changes Jul 16, 2024
View reviewed changes
pivanov
pivanov suggested changes Jul 17, 2024
View reviewed changes
examples/react/README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@AlienegraGeek AlienegraGeek requested a review from pivanov July 19, 2024 07:14
pivanov
pivanov previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)
r+

@AlienegraGeek AlienegraGeek dismissed pivanov’s stale review July 19, 2024 07:24

The merge-base changed after approval.

@frol
Copy link
Collaborator

frol commented Jul 19, 2024

@AlienegraGeek Sorry for jumping in, but I'd like to invite you to participate in the Race of Sloths - a fun and gamified open-source contributions program. Consider mentioning @race-of-sloths user in your github comment or PR description to join!

See how the flow works here: near/nearcore#11778

@AlienegraGeek
Copy link
Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jul 19, 2024 •
edited
Loading

@AlienegraGeek Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@trechriron trechriron mentioned this pull request Jul 24, 2024
Closed
14 tasks
@pivanov pivanov self-requested a review August 2, 2024 05:57
pivanov
pivanov previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@pivanov pivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@AlienegraGeek AlienegraGeek dismissed pivanov’s stale review August 2, 2024 05:58

The merge-base changed after approval.

@race-of-sloths
Copy link

❌ PR inactive

This PR has been inactive for two weeks. It's now marked as stale.

Tip

If you think it's a mistake, you can restart the bot with include command to proceed 🔄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trechriron trechriron trechriron left review comments

@pivanov pivanov pivanov left review comments

@hcho112 hcho112 Awaiting requested review from hcho112

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: NEW❗
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlienegraGeek @frol @race-of-sloths @pivanov @trechriron