Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to bitte wallet #1123

Merged
merged 5 commits into from
Jul 3, 2024
Merged

add support to bitte wallet #1123

merged 5 commits into from
Jul 3, 2024

Conversation

sainthiago
Copy link
Contributor

@sainthiago sainthiago commented Jun 26, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Summary
Bitte Wallet integration

PR summary
This PR contains the integration with Wallet selector of bitte-wallet.

ewiner and others added 4 commits June 18, 2024 21:03
Copy link
Contributor

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from small chore change, rest looks ok. But I have a question, is Bitte Wallet a new mintbase wallet?

we already do have mint base wallet and if you were to create bitte wallet which reference same mintbase wallet codebase, what would be the point?

If this is for purpose of rebranding, shouldn't this PR also prepare deprecation warning ?

README.md Show resolved Hide resolved
@rubenmarcus
Copy link
Contributor

Apart from small chore change, rest looks ok. But I have a question, is Bitte Wallet a new mintbase wallet?

we already do have mint base wallet and if you were to create bitte wallet which reference same mintbase wallet codebase, what would be the point?

If this is for purpose of rebranding, shouldn't this PR also prepare deprecation warning ?

its kinda of re-branding but is not, the version of @mintbase-js/wallet package is different it was introduced in this P/R https://github.com/Mintbase/mintbase-js/pull/517/files, we want to deprecate Mintbase Wallet, but also still support due to many people being connected to the old servers, as also dapps that already use it.

README.md Show resolved Hide resolved
hcho112
hcho112 previously approved these changes Jul 2, 2024
@trechriron trechriron changed the base branch from main to dev July 3, 2024 00:04
@trechriron trechriron dismissed hcho112’s stale review July 3, 2024 00:04

The base branch was changed.

@trechriron trechriron merged commit 0a1099a into near:dev Jul 3, 2024
11 checks passed
@trechriron trechriron mentioned this pull request Jul 24, 2024
14 tasks
@jackson-harris-iii
Copy link

@trechriron I'm having difficulty adding the bitte-wallet package as outlined in the README.md and I noticed there isn't a release of the wallet-selector library to npm since prior to this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants