-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to bitte wallet #1123
Conversation
Fix: fix lockfile for main branch
v8.9.10 Release (dev → main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from small chore change, rest looks ok. But I have a question, is Bitte Wallet a new mintbase wallet?
we already do have mint base wallet and if you were to create bitte wallet which reference same mintbase wallet codebase, what would be the point?
If this is for purpose of rebranding, shouldn't this PR also prepare deprecation warning ?
its kinda of re-branding but is not, the version of @mintbase-js/wallet package is different it was introduced in this P/R https://github.com/Mintbase/mintbase-js/pull/517/files, we want to deprecate Mintbase Wallet, but also still support due to many people being connected to the old servers, as also dapps that already use it. |
@trechriron I'm having difficulty adding the bitte-wallet package as outlined in the README.md and I noticed there isn't a release of the wallet-selector library to npm since prior to this update. |
Checklist:
Summary
Bitte Wallet integration
PR summary
This PR contains the integration with Wallet selector of bitte-wallet.