Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use deserializer from options if specified within getValueWithOptions function #402

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Use deserializer from options if specified within getValueWithOptions function #402

merged 2 commits into from
Jul 23, 2024

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Jul 20, 2024 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Custom deserializer provided into options isn't respected while querying data from LookupMap, Vector, etc

Test Plan

Related issues/PRs

@denbite denbite requested review from ailisp and volovyks as code owners July 20, 2024 20:41
@denbite denbite self-assigned this Jul 20, 2024
This was referenced Jul 20, 2024
Closed
Open
ailisp
ailisp approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks!

@ailisp ailisp merged commit da9c8b8 into develop Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

@volovyks volovyks Awaiting requested review from volovyks volovyks is a code owner

Assignees

@denbite denbite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denbite @ailisp