This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
GitHub actions added #969
Merged
GitHub actions added #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
May 19, 2022
| @@ -85,6 +84,10 @@ async function devDeploy(options) { | |||
| // Deploy with init function and args | |||
| const actions = [transactions.deployContract(readFileSync(options.wasmFile))]; | |||
|
|
|||
| if (options.initArgs && !options.initFunction) { | |||
| options.initFunction = 'new'; | |||
There was a problem hiding this comment.
Why we use this over default: 'new' ?
There was a problem hiding this comment.
@ailisp The idea is to be able not to set initFunction in CLI when it has the default name (new).
But when we are setting the default value of initFunction to new, args become mandatory even when you are not initializing the contract and it breaks the logic.
ailisp
approved these changes
May 19, 2022
|
@ailisp I will fix danger in a separate PR. Or just set API keys, looks like this is the problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.