Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

943 initFunction and initArgs logic is wrong #944

Merged
merged 1 commit into from
Mar 15, 2022
Merged

943 initFunction and initArgs logic is wrong #944

merged 1 commit into from
Mar 15, 2022

Conversation

willemneal
Copy link
Contributor

@willemneal willemneal commented Feb 24, 2022 •
edited
Loading

Use "new" if --initArgs is provided but --initFunction is not. fixes #943

@nearmax
@volovyk-s

MaksymZavershynskyi
MaksymZavershynskyi suggested changes Feb 26, 2022
View reviewed changes
Copy link

@MaksymZavershynskyi MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire logic can be fixed by setting default of initFunction to "new".

@volovyks volovyks self-requested a review March 15, 2022 11:09
@volovyks volovyks merged commit 036972a into near:master Mar 15, 2022
@willemneal willemneal deleted the fix/943 branch March 23, 2022 14:22
@kalloc
Copy link

kalloc commented Apr 24, 2022 •
edited
Loading

@volovyk-s
Hi, but what about contract re-deploy/upgrade? I understand that initFunction for migration not always required.

@volovyks
Copy link
Collaborator

@kalloc yes, new as default caused some bugs. Addressed in #969

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@volovyks volovyks volovyks approved these changes

@MaksymZavershynskyi MaksymZavershynskyi Awaiting requested review from MaksymZavershynskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

initFunction and initArgs logic is wrong
4 participants
@willemneal @kalloc @volovyks @MaksymZavershynskyi