Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Add a util for explorer functionality + unit tests #448

Merged
merged 6 commits into from
Jul 10, 2020
Merged

Conversation

janedegtiareva
Copy link
Contributor

@janedegtiareva janedegtiareva commented Jul 9, 2020

near send will now print a link to explorer url at the end of the output, if there is a known explorer url and also if transaction id is known.

This is needed for #410

@janedegtiareva janedegtiareva requested review from mikedotexe and chadoh and removed request for mikedotexe July 9, 2020 21:00
@mikedotexe
Copy link
Contributor

This is great! I think the full log is more verbose than we want to be. I think the transaction hash is all that we really want if I'm understanding this ticket correctly.

Screenshot 2020-07-09 14 29 44

Screenshot 2020-07-09 14 27 30

Link worked great to me :)

package.json Show resolved Hide resolved
@mikedotexe
Copy link
Contributor

Looks like there's linting issues in three files, too

@janedegtiareva
Copy link
Contributor Author

Looks like there's linting issues in three files, too

I already fixed linter issues

@janedegtiareva
Copy link
Contributor Author

re full response too verbose: I agree, and it also is not very user friendly. I was going to address that in a follow up PR so that the actual explorer work lands with a smaller surface area.

@mikedotexe
Copy link
Contributor

re full response too verbose: I agree, and it also is not very user friendly. I was going to address that in a follow up PR so that the actual explorer work lands with a smaller surface area.

I think it's got everything we need, just call getTxnId so it says
Transaction ID: 234kljsdklfjk3l43
View this transaction:
https://explorer.…

Copy link
Contributor

@mikedotexe mikedotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @janedegtiareva

@janedegtiareva janedegtiareva merged commit 0913ec5 into master Jul 10, 2020
@janedegtiareva janedegtiareva deleted the explorer branch July 10, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants