Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.3.0] lockup: Add lockup options #89

Merged
merged 7 commits into from
Aug 13, 2020
Merged

[0.3.0] lockup: Add lockup options #89

merged 7 commits into from
Aug 13, 2020

Conversation

evgenykuzyakov
Copy link
Collaborator

@evgenykuzyakov evgenykuzyakov commented Aug 10, 2020 •
edited
Loading

  • Introduced optional release duration
  • Introduced optional absolute lockup timestamp.
  • Updated init arguments
    • Added optional absolute lockup_timestamp.
    • Renamed lockup_start_information to transfers_information. Also renamed internal timestamp to transfers_timestamp.
    • Added optional release_duration to linearly release tokens.

TODO:

  • Add README examples for absolute timestamp and release duration
  • Add integration test for release duration

Test plan:

  • Added unit tests to cover absolute lockup timestamp and release duration.
  • Existing unit/integration tests.

bowenwang1996
bowenwang1996 reviewed Aug 11, 2020
View reviewed changes
lockup/src/getters.rs Outdated Show resolved Hide resolved
lockup/src/getters.rs Show resolved Hide resolved
willemneal
willemneal reviewed Aug 11, 2020
View reviewed changes
lockup/README.md Outdated Show resolved Hide resolved
Evgeny Kuzyakov and others added 4 commits August 11, 2020 10:37
@bowenwang1996
Update lockup/src/getters.rs
9c058f2 
Co-authored-by: Bowen Wang <bowenwang1996@users.noreply.github.com>
Update lockup/README.md
8964b06 
Co-authored-by: Willem Wyndham <willem@cs.umd.edu>
Rebuild
f2f31c8
Add examples to README
f863973
@evgenykuzyakov evgenykuzyakov marked this pull request as ready for review August 11, 2020 22:39
@evgenykuzyakov evgenykuzyakov merged commit cad998e into master Aug 13, 2020
@evgenykuzyakov evgenykuzyakov deleted the add-lockup-options branch August 13, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal left review comments

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@ilblackdragon ilblackdragon Awaiting requested review from ilblackdragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykuzyakov @willemneal @bowenwang1996