Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore files match ignore-glob even if it is explicit provided under arg like --git in cmd #1554

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

soulomoon
Copy link
Contributor

@soulomoon soulomoon commented Jan 14, 2024

It should fix problems such as with "--git:, would not ignore files matching the ignore-glob
Should fix #1552

@soulomoon
Copy link
Contributor Author

Should ignore-glob filter out all files even if they are provided explicit such as with arg --git
At least with --git, we should filter out files matching ignore-glob, for example, the test data files with .hs suffix.
we have a use case in haskell-language-server
haskell/haskell-language-server#3901 (comment)

@soulomoon soulomoon changed the title ignore files match ignore-glob even if it is explicit provided as in cmd ignore files match ignore-glob even if it is explicit provided under arg like --git in cmd Jan 14, 2024
@ndmitchell ndmitchell merged commit 9d24fe1 into ndmitchell:master Jan 14, 2024
0 of 5 checks passed
@ndmitchell
Copy link
Owner

Thanks! Great fix. Definitely should combine them since they do work together quite sensibly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hlint --ignore-glob seem not to be working correctly
2 participants