Suggest: '(& f)' -> 'f' #1274
Closed
Suggest: '(& f)' -> 'f' #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndmitchell
reviewed
Aug 6, 2021
There was a problem hiding this comment.
Thanks for the hint! I thought we already had this one included in the standard defaults with
Line 322 in c00bb3d
|
Mind you, I am totally new to hlint internals. But indeed, the existing
rule for Data.Function.& (which I missed) does not fire for my test
case:
```
***@***.***:~/Projects/Haskell/hlint$ cat test.hs
module Main where
import Control.Lens
main :: IO ()
main = do
print $ (& (+ 1)) 0
***@***.***:~/Projects/Haskell/hlint$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
***@***.***:~/Projects/Haskell/hlint$ hlint --hint data/hlint.yaml test.hs
No hints
***@***.***:~/Projects/Haskell/hlint$ git checkout redunant
Switched to branch 'redunant'
Your branch is up to date with 'origin/redunant'.
***@***.***:~/Projects/Haskell/hlint$ hlint --hint data/hlint.yaml test.hs
test.hs:7:11-19: Warning: Redundant &
Found:
(& (+ 1))
Perhaps:
(+ 1)
1 hint
```
…--
CYa,
⡍⠁⠗⠊⠕
|
ndmitchell
added a commit
that referenced
this pull request
Aug 8, 2021
|
I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the pull request!
By raising this pull request you confirm you are licensing your contribution under all licenses that apply to this project (see LICENSE) and that you have no patents covering your contribution.
If you care, my PR preferences are at https://github.com/ndmitchell/neil#contributions, but they're all guidelines, and I'm not too fussy - you don't have to read them.