Support for '&' operator (similar to '$') #1201 #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could we get some tests? Probably in data/hlint.yaml, something like |
Alternate solution: ndmitchell#1203
Done, added this one and another test |
yairchu
added a commit
to lamdu/lamdu
that referenced
this pull request
Jan 15, 2021
(using ndmitchell/hlint#1204)
|
Thanks! That second test you wrote of zipWithM is something I'd have never figured out by eye, and the change is very simple, so any doubts I may have originally had about supporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to work, triggers 3 hints for Lamdu and they appear to be correct :)
I suppose we may also want to add tests for these, but I also suggested #1203 which might be a different solution to consider.