Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parentheses with tuple sections and operator sections #1196

Closed
josephcsible opened this issue Jan 1, 2021 · 2 comments
Closed

Missing parentheses with tuple sections and operator sections #1196

josephcsible opened this issue Jan 1, 2021 · 2 comments

Comments

@josephcsible
Copy link
Contributor

HLint will suggest turning flip (,) (+ 1) into (, + 1), which is invalid. It should instead turn it into (, (+ 1)).
@ndmitchell
Copy link
Owner

Thanks for the report. I note that map (+ 1) . map (+ 2) gets the correct suggestion of map ((+ 1) . (+ 2)) so there must be something a bit funky with just that suggestion... I'll investigate.

ndmitchell added a commit that referenced this issue Jan 2, 2021
@ndmitchell
#1196, fix removed parens with operator sections in some cases
f1effbf
@ndmitchell
Copy link
Owner

Thanks! We have to deal with sections properly, and we were in remParen, but not fromParen or fromParen1. I made the latter two delegate to remParen, so hopefully fixed now.

ndmitchell added a commit that referenced this issue Jan 2, 2021
@ndmitchell
#1196, fix an accident infinite loop introduced
906142f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndmitchell @josephcsible