Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waterDayYear()/fetchHenry(): add optional tz argument #223

Merged
merged 2 commits into from
Dec 10, 2021
Merged

waterDayYear()/fetchHenry(): add optional tz argument #223

merged 2 commits into from
Dec 10, 2021

Conversation

brownag
Copy link
Member

@brownag brownag commented Dec 8, 2021

  • used for consistent POSIX time conversion in tests where date/time has granularity finer than one day

I thought I had resolved this for winbuilder by changing 00:00:00 to 12:00:00, but this still fails with whatever locale the M1 mac testing on CRAN is using.

Version: 2.6.9
Check: tests
Result: ERROR
     Running ‘testthat.R’ [7s/8s]
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
    
     ══ Failed tests ════════════════════════════════════════════════════════════════
     ── Failure (test-fetchHenry.R:207:3): .formatDates() works as expected ─────────
     res$water_day not equal to c(140L, 93L).
     2/2 mismatches (average diff: 1)
     [1] 139 - 140 == -1
     [2] 92 - 93 == -1
     ── Failure (test-waterDayYear.R:57:3): works as expected ───────────────────────
     res$wd not equal to 66L.
     1/1 mismatches
     [1] 65 - 66 == -1
    
     [ FAIL 2 | WARN 0 | SKIP 72 | PASS 194 ]
     Error: Test failures
     Execution halted
Flavor: r-release-macos-arm64

brownag and others added 2 commits December 8, 2021 09:04
@brownag
waterDayYear()/fetchHenry(): allow optional tz argument
331205b 
 - used for consistent POSIX time conversion in tests where date/time has granularity finer than one day
@brownag
Merge branch 'master' into cranfixWaterYear
bb3bde4
@brownag
Copy link
Member Author

brownag commented Dec 8, 2021

This passes on winbuilder; I am inclined to submit this fix to CRAN within next couple days.

@dylanbeaudette
Copy link
Member

Go for it. I'm looking into storing the TZ offset as sensor metadata vs. embedded in the date/time string.

@brownag brownag merged commit edf5ec1 into master Dec 10, 2021
@brownag brownag deleted the cranfixWaterYear branch December 14, 2021 03:35
@brownag brownag mentioned this pull request Oct 5, 2022
Closed
@brownag brownag mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brownag @dylanbeaudette