hotfix: #513 -> :next #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pato23arg
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
|
Can we add a unit test for this one please ? |
UTs incorporated. |
…ig_compliance.py
Thanks for taking ownership on that ! LGTM |
mzbroch
approved these changes
Jun 12, 2023
|
@itdependsnetworks @jeffkala Please review. |
|
hotfix should be to develop, unless this was only introduced in next? The issues was not descriptive enough for me to understand what this is doing, can you add pre change output vs post change output? |
This was only introduced in next. Pre-change, compliance jobs fail with AttributeError: config_to_match does not exist. |
itdependsnetworks
approved these changes
Jun 12, 2023
2 tasks
itdependsnetworks
deleted the
513-native-json-support-get_config_element-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix: linked to issue #513