-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED] Get rid of server dev dependencies in nats package #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
move-server-tests
branch
from
October 13, 2023 20:56
656ce1b
to
1a13c93
Compare
piotrpio
force-pushed
the
move-server-tests
branch
from
October 13, 2023 23:11
a6ccbf4
to
4065e27
Compare
Confirmed this approach would work as below ✅ $ echo '
package main
import (
"github.com/nats-io/nats.go"
)
func main() {
// Connect to a server
nc, _ := nats.Connect(nats.DefaultURL)
// Simple Publisher
nc.Publish("foo", []byte("Hello World"))
}
' > main.go
$ go mod init example.com/example
$ go mod edit -require github.com/nats-io/nats.go@move-server-tests
$ go mod tidy
go: downloading github.com/nats-io/nats.go v1.30.3-0.20231013231123-4065e270471b
$ cat go.mod
module example.com/example
go 1.21.2
require github.com/nats-io/nats.go v1.30.3-0.20231013231123-4065e270471b
require (
github.com/klauspost/compress v1.17.0 // indirect
github.com/nats-io/nkeys v0.4.5 // indirect
github.com/nats-io/nuid v1.0.1 // indirect
golang.org/x/crypto v0.6.0 // indirect
golang.org/x/sys v0.5.0 // indirect
)
$ go build .
$ go version -m example
example: go1.21.2
path example.com/example
mod example.com/example (devel)
dep github.com/klauspost/compress v1.17.0 h1:Rnbp4K9EjcDuVuHtd0dgA4qNuv9yKDYKK1ulpJwgrqM=
dep github.com/nats-io/nats.go v1.30.3-0.20231013231123-4065e270471b h1:gFa8SUr5qFCHvtpGoDMvGwzs106hBZiDWo37JO7EaHU=
dep github.com/nats-io/nkeys v0.4.5 h1:Zdz2BUlFm4fJlierwvGK+yl20IAKUm7eV6AAZXEhkPk=
dep github.com/nats-io/nuid v1.0.1 h1:5iA8DT8V7q8WK2EScv2padNa/rTESc1KdnPw4TC2paw=
dep golang.org/x/crypto v0.6.0 h1:qfktjS5LUO+fFKeJXZ+ikTRijMmljikvG68fpMMruSc=
dep golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU=
build -buildmode=exe
build -compiler=gc
build CGO_ENABLED=1
build CGO_CFLAGS=
build CGO_CPPFLAGS=
build CGO_CXXFLAGS=
build CGO_LDFLAGS=
build GOARCH=amd64
build GOOS=darwin
build GOAMD64=v1
build vcs=git
build vcs.revision=960f37f30fc9728329b75b5a937d1714c94e1ad3
build vcs.time=2023-10-13T23:12:01Z
build vcs.modified=true |
piotrpio
force-pushed
the
move-server-tests
branch
from
October 13, 2023 23:26
4065e27
to
ae0f038
Compare
wallyqs
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when it is ready and CI green.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
piotrpio
force-pushed
the
move-server-tests
branch
from
October 13, 2023 23:41
ae0f038
to
7f86ee0
Compare
This was referenced Oct 15, 2023
Merged
2 tasks
This is awesome thanks so much 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test
directory-tags=internal_testing
for tests that depend on internals not exposed via public API