Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] SkipConsumerLookup option in js.Subscribe() #1265

Merged
merged 2 commits into from
May 16, 2023

Conversation

piotrpio
Copy link
Collaborator

This adds SkipConsumerLookup() SubOpt, allowing to omit calling CONSUMER.INFO when creating JetStream subscription.

wallyqs and others added 2 commits May 15, 2023 11:52
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from wallyqs May 15, 2023 09:54
@coveralls
Copy link

Coverage Status

Coverage: 85.269% (+0.06%) from 85.211% when pulling 022b889 on skip-consumer-lookup into 2765665 on main.

js.go Outdated
skipCInfo bool
}

func SkipConsumerInfo() SubOpt {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe SkipConsumerLookup?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're looking at diff from single commit, it's called SkipConsumerLookup() :)

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit 8faa842 into main May 16, 2023
@piotrpio piotrpio deleted the skip-consumer-lookup branch May 16, 2023 15:48
@piotrpio piotrpio mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants