-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated usage of "io/ioutil" #1150
chore: remove deprecated usage of "io/ioutil" #1150
Conversation
closes #1149 |
go.mod
Outdated
@@ -3,6 +3,9 @@ module github.com/nats-io/nats.go | |||
go 1.16 | |||
|
|||
require ( | |||
github.com/golang/protobuf v1.5.2 | |||
github.com/nats-io/nats-server/v2 v2.9.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cesarvspr for the PR! You can avoid changing both go.mod
and go.sum
by running the tests as follows:
go test -modfile=go_test.mod ./...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, thanks! Any idea why tests are intermittent on the pipeline? @wallyqs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it was just a flaky test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! As per @wallyqs comment, please clean up go.mod
and go.sum
(they should not contain test-only dependencies), then LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.