Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables Action issue when changing language #3391

Closed
mhenkens opened this issue Jun 23, 2022 · 0 comments · Fixed by #3400
Closed

Tables Action issue when changing language #3391

mhenkens opened this issue Jun 23, 2022 · 0 comments · Fixed by #3400
Labels
comp: stark-ui status: done type: bug

Comments

@mhenkens
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

In table when in NL and data are refresh, we got and error

Expected behavior

No error when changing the language to NL

Minimal reproduction of the problem with instructions

In the showcase
change the language to NL
switch page and you get an error

What is the motivation / use case for changing the behavior?

Possibilities to translate the application in NL

Environment


Angular version: 7.x
Stark version: 10.2
@mhenkens mhenkens self-assigned this Jun 23, 2022
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 23, 2022
@mhenkens
fix(stark-ui): fix issue with table on action NationalBankBelgium#3391
0e5d165 
When changing language we got an issue with the name of the column for the Actions in NL
Test are
updated as well.

ISSUES CLOSED: NationalBankBelgium#3391
@mhenkens mhenkens mentioned this issue Jun 23, 2022
Merged
3 tasks
SuperITMan added a commit that referenced this issue Jun 23, 2022
@SuperITMan
Merge pull request #3392 from mhenkens/bugfix/3391
53c5e7c 
fix(stark-ui): fix issue with table on action #3391
@mhenkens mhenkens removed their assignment Jun 23, 2022
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 27, 2022
@mhenkens
fix(stark-ui): short correction about code quality
8dab8e4 
When changing language we got an issue with the name of the column for the Actions in NL
Test
are
updated as well.
ISSUES CLOSED: NationalBankBelgium#3391
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 27, 2022
@mhenkens
fix(stark-ui): fix issue with table on action
bb5682c 
When changing language we got an issue with the name of the column for the Actions in NL

ISSUES CLOSED: NationalBankBelgium#3391
@mhenkens mhenkens mentioned this issue Jun 27, 2022
Merged
3 tasks
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 30, 2022
@mhenkens
fix(stark-ui): table action column do not works when language is NL
20c010e 
When changing language we got an issue with the name of the column for the Actions in NL
The column definition name was translated bt shouldn't because it used
to get the action in the row object via the 'Actions' property

ISSUES CLOSED: NationalBankBelgium#3391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui status: done type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stark-ui): fix issue with table on action mhenkens/stark
1 participant
@mhenkens