Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.3 merge to master #5157

Merged
merged 13 commits into from
May 3, 2022
Merged

2.0.3 merge to master #5157

merged 13 commits into from
May 3, 2022

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 3, 2022

Describe your changes:

Merges release/2.0.3 into master

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

shefalijoshi and others added 13 commits April 25, 2022 11:58
* [2297] When there is no display range or range, skip setting the range value when auto scale is turned off.

* If the formatted value is a number and a float, set precision to 2 decimal points.

* Fix value assignment

* Use whole numbers in log mode

* Revert whole numbers fix - need floats for values between 0 and 1.
* Scroll to focused image when view resizes - this will force scrolling to focused image when going to/from view large mode

* Scroll to the right if there is no paused focused image
* Use telemetry collections to handle bounds checks
…ge (#5116)

* Added animation styling for POS and CAM; adjusted cutoff for isNewImage

* Remove animation from POS and CAM
#5132)

* use object (map) instead of set to track dirty objects
* fix tests due to internals change

Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
* Gauge plugin #4896, add edit mode
* Improve sizing strategy for gauges.
* Do not install gauge by default for now

Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Co-authored-by: Jamie Vigliotta <jamie.j.vigliotta@nasa.gov>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: unlikelyzero <jchill2@gmail.com>
@shefalijoshi shefalijoshi requested a review from unlikelyzero May 3, 2022 17:56
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #5157 (3fcb4ac) into master (b77a406) will increase coverage by 0.04%.
The diff coverage is 43.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5157      +/-   ##
==========================================
+ Coverage   49.89%   49.93%   +0.04%     
==========================================
  Files         533      534       +1     
  Lines       19516    19548      +32     
  Branches     1759     1767       +8     
==========================================
+ Hits         9737     9762      +25     
- Misses       9338     9340       +2     
- Partials      441      446       +5     
Impacted Files Coverage Δ
src/MCT.js 97.82% <ø> (-0.03%) ⬇️
...plugins/displayLayout/components/TelemetryView.vue 2.80% <0.00%> (+0.28%) ⬆️
...c/plugins/gauge/components/GaugeFormController.vue 0.00% <ø> (ø)
src/plugins/plot/MctTicks.vue 68.42% <ø> (ø)
...gins/plot/stackedPlot/mixins/objectStyles-mixin.js 59.18% <ø> (-0.44%) ⬇️
src/plugins/plot/tickUtils.js 71.83% <ø> (+1.96%) ⬆️
src/ui/components/ObjectView.vue 44.80% <ø> (+0.72%) ⬆️
src/plugins/imagery/components/ImageryView.vue 35.75% <11.11%> (+2.24%) ⬆️
...ins/conditionWidget/components/ConditionWidget.vue 24.44% <21.95%> (-38.06%) ⬇️
src/plugins/gauge/components/Gauge.vue 59.20% <50.00%> (-1.46%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77a406...3fcb4ac. Read the comment docs.

@shefalijoshi shefalijoshi merged commit c089a47 into master May 3, 2022
@shefalijoshi shefalijoshi deleted the master-2.0.3 branch May 3, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants