Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-3377: Add configurable metrics integration SNS access policy to report topics #3482

Merged
merged 10 commits into from
Sep 30, 2023
Merged

CUMULUS-3377: Add configurable metrics integration SNS access policy to report topics #3482

merged 10 commits into from
Sep 30, 2023

Conversation

botanical
Copy link
Member

@botanical botanical commented Sep 22, 2023 •
edited
Loading

Summary: Summary of changes

Addresses CUMULUS-3377: Cloud Metrics would like a flag for metrics integrations that will update SNS topic access policies

Changes

  • Added new variable to enable policy addition to SNS topics used for metrics reporting.

Testing

  • Local and cross account testing has been done and is successful
  • Testing has been done for the scenario that a user does not provide value for report_sns_topic_subscriber_arns

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@botanical botanical marked this pull request as ready for review September 25, 2023 15:50
jennyhliu
jennyhliu reviewed Sep 26, 2023
View reviewed changes
jennyhliu
jennyhliu approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jennyhliu jennyhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work👍

@botanical botanical merged commit 3e82063 into master Sep 30, 2023
@botanical botanical deleted the CUMULUS-3377 branch September 30, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyhliu jennyhliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@botanical @jennyhliu