-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace plupload with uppy #30
Conversation
Nice one, thanks. I was also planning to replace plupload, but couldn't decide which one to replace with. I'll check the code asap and merge it. Thanks for the contribution. |
I made some changes, I would be happy if you check it.
|
Yea is kinda dumb show entire message from the server response on the file status, but other issue I encountered is if I try put them into the below messagebox it would be super long, should I just make message box scrollable and file status as simple |
So I made some changes now it looks better on dark mode. Tailwind for me is very painful deal with, is this the way future devs gonna really writing this for now, back in before CSS is thing? I add some line breaks on class so I can actually knowing which part is which, we should extract them as @apply or components, otherwise this is hell to maintain. Currently looks like this on upload modal, should apply for other stuff: I did dynamic import uppy locales but it just give me ONE HUNDRED FILES on build, we need figure out a better way to do this. |
updated localization can you check it..
|
Oh yea just import uppy locale from our locale is definitely better, we should do that |
we have a merge conflict :) |
I saw that, let me just handle that right now |
already cleaned up. :) ok Ill leave to you from here. I'll check it again later. (still need to find a way to filter locales and only selected locales to be compiled) |
Nice! |
I missed this part, yes with this It is very hard to maintain. But when you feel comfortable, you barely need to touch css files again. And you get the things done in just a second. There are 2 options to simplify it, first one is to use @apply, the other one is to break everything to components like in React. I think, we should go for using @apply. |
Yea we can go for |
demo in the vuefinder.ozdemir.be is updated.
otherwise it seems all good. thanks again. |
https://www.youtube.com/watch?v=Gd5lmAb4Iqw I'll leave this here. It will help to simplify things later. |
Thank you, I look up later. |
<div class="vuefinder" :ref="props.id">
|
Oh god I think my explanation is even more confusing, basically Also I think you mixed reply.. |
Yea thats right. Im using vue2 and other libraries with my other projects, and confused a bit. yea its all good :) no worries. |
So what I did is I replaced Plupload with Uppy.
Plupload is okay but it doesn't upload multiple files at same time. Both are in simliar download size, so that's good. Uppy supports more ways to upload your files, even from a webcam if we really want that 😂.
Added drag'n'drop to upload modal, if we can just add that to explorer it would be even better.
Upload performance is noticeable better than plupload when there's a lot of files in queue, thanks to Uppy XHR plugin's parallel upload support. Currently I hard-coded parallels limit to 5, maybe we can expose this param to user.
Also some additional tweaks, like:
npm run dev
to get things to start.