-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model converter #480
Merged
Merged
Model converter #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgray
force-pushed
the
ross/model-converter-v2
branch
3 times, most recently
from
August 14, 2024 12:49
c7d9ec2
to
90f8816
Compare
This reverts commit 8847cd1.
rossgray
force-pushed
the
ross/model-converter-v2
branch
from
August 22, 2024 13:03
f532b8f
to
39b3dcb
Compare
MPCherry
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request outline
Support running models created with other frameworks (for now we only support Cog).
This PR makes the following changes:
pipeline container up
(we need to run 2 containers)Manager
class an abstract base class and add a newCogManager
implementation (this forwards requests from the pipeline wrapper container onto the Cog container)Still to do:
Checklist: