Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model converter #480

Merged
merged 40 commits into from
Sep 9, 2024
Merged

Model converter #480

merged 40 commits into from
Sep 9, 2024

Conversation

rossgray
Copy link
Contributor

@rossgray rossgray commented Aug 13, 2024

Pull request outline

Support running models created with other frameworks (for now we only support Cog).

This PR makes the following changes:

  • Allow Cog models to run locally via pipeline container up (we need to run 2 containers)
  • Make the Manager class an abstract base class and add a new CogManager implementation (this forwards requests from the pipeline wrapper container onto the Cog container)
  • Some of the container commands have been refactored slightly to make it easier to work with

Still to do:

  • Update reference to Cog pipeline wrapper image

Checklist:

  • Docs updated
  • Version bumped

@rossgray rossgray force-pushed the ross/model-converter-v2 branch 3 times, most recently from c7d9ec2 to 90f8816 Compare August 14, 2024 12:49
@rossgray rossgray force-pushed the ross/model-converter-v2 branch from f532b8f to 39b3dcb Compare August 22, 2024 13:03
@rossgray rossgray marked this pull request as ready for review August 22, 2024 14:56
@rossgray rossgray merged commit 34f2c38 into main Sep 9, 2024
5 checks passed
@rossgray rossgray deleted the ross/model-converter-v2 branch September 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants