Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for JDK 1.6 and 1.7 at build definitions #1207

Closed
4 tasks done
kazuki43zoo opened this issue Mar 16, 2018 · 6 comments · Fixed by #1209
Closed
4 tasks done

Drop support for JDK 1.6 and 1.7 at build definitions #1207

kazuki43zoo opened this issue Mar 16, 2018 · 6 comments · Fixed by #1209
Assignees
@kazuki43zoo
Labels
enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version
Milestone
3.5.0

Comments

@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 16, 2018 •
edited
Loading

The MyBatis 3.5.0 will support JDK 8+.

Tasks

Notes

This issue will fix only build definition. I will propose that source code polishing performs using other issues.
@kazuki43zoo kazuki43zoo added this to the 3.5.0 milestone Mar 16, 2018
@jeffgbutler
Copy link
Member

Does JDK 7 actually benefit anyone? Maybe we should jump to 8.

@kazuki43zoo
Copy link
Member Author

Can jump to JDK 8 as support policy of MyBatis core? If it is OK, I agree with @jeffgbutler 's opinion.

@harawata
Copy link
Member

It's more like to support users who are using (or want to use) MyBatis in Java 7 projects that are not easily upgraded to newer versions for various reasons.
Or, maybe the world has become a better place and everybody is using Java 8+?

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Drop JDK6 on travis build mybatis#1207
5534358
@kazuki43zoo kazuki43zoo added the no backward compatibility Includes change no backward compatibility for previous version label Mar 16, 2018
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Drop maven profile for JDK6 mybatis#1207
78fb8f4
@jeffgbutler
Copy link
Member

I am trapped in the JDK7 world too, unfortunately. My point is that I don't think there is enough difference between JDK6 and JDK7 to make it worth it. What would we actually change in the code for JDK7? Switch to diamond syntax? Yawn. I freely admit that I may be missing something cool we could do in JDK7 - so please let me know if there is something like that.

For my commercial projects, version 3.4.6 has everything I need and more. I would support version 3.5.0 going to JDK8 and stating clearly that 3.4.6 is the version we support on JDK6 and JDK7.

@harawata
Copy link
Member

Good point. +1 to requiring Java 8 then.
We can release 3.4.7 for Java 6, 7 users if it's really necessary.

@kazuki43zoo kazuki43zoo changed the title Drop support for JDK 1.6 Drop support for JDK 1.6 and 1.7 Mar 16, 2018
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Refine build definition for droping JDK6 mybatis#1207
294c130
@h3adache
Copy link
Member

We had this discussion on the dev list I believe.
I'm would definitely support @jeffgbutler's idea though. The sooner we move to JDK 8 the better

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Drop JDK7 on travis build mybatis#1207
23b1117
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Drop maven profile for JDK7 mybatis#1207
b13e166
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Refine build definition for droping JDK7 mybatis#1207
4a5065c
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Upgrade to dependency artifacts mybatis#1207
c6454cd 
* log4j-core 2.3 -> 2.5
* cglib 3.2.5 -> 3.2.6
* junit-vintage-engine 4.12.2 -> 5.1.0
* hsqldb 2.3.5 -> 2.4.0
* derby 10.12.1.1 -> 10.14.1.0
* mockito-core 2.12.0 -> 2.16.0
* commons-dbcp 1.x -> commons-dbcp2 2.2.0
* jboss-transaction-api_1.2_spec 1.0.1 -> 1.1.1
* postgresql 42.1.4.jre6 -> 42.2.1
* assertj-core 1.7.1 -> 3.9.1
* catch-exception 1.4.4 -> 1.4.6
* postgresql-embedded 2.5 -> 2.8
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 16, 2018
@kazuki43zoo
Upgrade dependency artifacts to latest version mybatis#1207
862b770 
* log4j-core 2.3 -> 2.5
* cglib 3.2.5 -> 3.2.6
* junit-vintage-engine 4.12.2 -> 5.1.0
* hsqldb 2.3.5 -> 2.4.0
* derby 10.12.1.1 -> 10.14.1.0
* mockito-core 2.12.0 -> 2.16.0
* commons-dbcp 1.x -> commons-dbcp2 2.2.0
* jboss-transaction-api_1.2_spec 1.0.1 -> 1.1.1
* postgresql 42.1.4.jre6 -> 42.2.1
* assertj-core 1.7.1 -> 3.9.1
* catch-exception 1.4.4 -> 1.4.6
* postgresql-embedded 2.5 -> 2.8
@kazuki43zoo kazuki43zoo changed the title Drop support for JDK 1.6 and 1.7 Drop support for JDK 1.6 and 1.7 at build definitions Mar 17, 2018
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 17, 2018
@kazuki43zoo
Upgrade to maven-wrapper 0.4.0 mybatis#1207
f24b563
@kazuki43zoo kazuki43zoo mentioned this issue Mar 17, 2018
Merged
@kazuki43zoo kazuki43zoo added the enhancement Improve a feature or add a new feature label Mar 18, 2018
This was referenced Mar 18, 2018
Closed
Closed
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Drop JDK6 on travis build mybatis#1207
45cf64c
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Drop maven profile for JDK6 mybatis#1207
a84f67c
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Refine build definition for droping JDK6 mybatis#1207
e3c73bc
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Drop JDK7 on travis build mybatis#1207
4cf9c5a
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Drop maven profile for JDK7 mybatis#1207
59229e3
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Refine build definition for droping JDK7 mybatis#1207
490ac00
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Upgrade dependency artifacts to latest version mybatis#1207
bc7ed62 
* log4j-core 2.3 -> 2.5
* cglib 3.2.5 -> 3.2.6
* junit-vintage-engine 4.12.2 -> 5.1.0
* hsqldb 2.3.5 -> 2.4.0
* derby 10.12.1.1 -> 10.14.1.0
* mockito-core 2.12.0 -> 2.16.0
* commons-dbcp 1.x -> commons-dbcp2 2.2.0
* jboss-transaction-api_1.2_spec 1.0.1 -> 1.1.1
* postgresql 42.1.4.jre6 -> 42.2.1
* assertj-core 1.7.1 -> 3.9.1
* catch-exception 1.4.4 -> 1.4.6
* postgresql-embedded 2.5 -> 2.8
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Update to maven 3.5.2 mybatis#1207
adcbfbd
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Change artifact to javax.transaction:javax.transaction-api mybatis#1207
f471b32
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Upgrade to mybatis-parent to 31-SNAPSHOT mybatis#1207
b1f9387
@kazuki43zoo kazuki43zoo self-assigned this Mar 19, 2018
This was referenced Mar 19, 2018
Closed
Closed
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Jun 23, 2018
@kazuki43zoo
Drop special logics and annotation that indicates using java 8 and 7
257b4ce 
Related with mybatis#1207
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Jun 23, 2018
@kazuki43zoo
Drop special logics and annotation that indicates using java 8 and 7
a2ef920 
Related with mybatis#1207
This was referenced Jun 23, 2018
Merged
Merged
@wangwei-ying wangwei-ying mentioned this issue Nov 29, 2019
Merged
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Drop JDK6 on travis build mybatis#1207
38d0a0d
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Drop maven profile for JDK6 mybatis#1207
12a3586
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Refine build definition for droping JDK6 mybatis#1207
780f111
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Drop JDK7 on travis build mybatis#1207
76415ee
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Drop maven profile for JDK7 mybatis#1207
abb264c
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Refine build definition for droping JDK7 mybatis#1207
4adc79a
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Upgrade dependency artifacts to latest version mybatis#1207
e2ad866 
* log4j-core 2.3 -> 2.5
* cglib 3.2.5 -> 3.2.6
* junit-vintage-engine 4.12.2 -> 5.1.0
* hsqldb 2.3.5 -> 2.4.0
* derby 10.12.1.1 -> 10.14.1.0
* mockito-core 2.12.0 -> 2.16.0
* commons-dbcp 1.x -> commons-dbcp2 2.2.0
* jboss-transaction-api_1.2_spec 1.0.1 -> 1.1.1
* postgresql 42.1.4.jre6 -> 42.2.1
* assertj-core 1.7.1 -> 3.9.1
* catch-exception 1.4.4 -> 1.4.6
* postgresql-embedded 2.5 -> 2.8
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Update to maven 3.5.2 mybatis#1207
757428e
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Change artifact to javax.transaction:javax.transaction-api mybatis#1207
0d5013e
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Upgrade to mybatis-parent to 31-SNAPSHOT mybatis#1207
a45c417
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Drop special logics and annotation that indicates using java 8 and 7
0059bc0 
Related with mybatis#1207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazuki43zoo kazuki43zoo

Labels
enhancement Improve a feature or add a new feature no backward compatibility Includes change no backward compatibility for previous version
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Drop support JDK 6 and 7 at build definitions kazuki43zoo/mybatis-3
4 participants
@harawata @h3adache @jeffgbutler @kazuki43zoo