Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect if sudo should be used #138

Merged
merged 5 commits into from
Oct 18, 2022
Merged

detect if sudo should be used #138

merged 5 commits into from
Oct 18, 2022

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Oct 9, 2022

Fix #135

Note : I would like you to merge #137 first, so I can modify the container test matrix in this PR

@iTrooz iTrooz requested review from mxschmitt and dscho as code owners October 9, 2022 13:00
@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 13, 2022

Rebased on master & tested !

dscho
dscho reviewed Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just have two suggestions how to improve this PR, @iTrooz please let me know whether you agree or not.

action.yml Outdated Show resolved Hide resolved
src/helpers.js Outdated Show resolved Hide resolved
@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 17, 2022

Done ! Is this what you had in mind ?

dscho
dscho approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@mxschmitt mxschmitt merged commit ac30c9d into mxschmitt:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

@mxschmitt mxschmitt Awaiting requested review from mxschmitt mxschmitt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default behaviour of sudo
3 participants
@iTrooz @dscho @mxschmitt