Specify PendingIntent mutability in getArtworkInfo() within MuzeiArtProvider #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Muzei plugins that target API 31 and when run on Android 12.0+ cannot view artwork information An API level check is included to maintain compatability with Android versions lower than M
|
Similar to d4f348a, please use |
PendingIntent.FLAG_IMMUTABLE flag has no effect when used on API levels lower than M
|
Yes you are correct, the flag will have no effect on lower API levels because the flag is simply a toggled bit within a bit field. The changes have been made as you requested |
|
Thanks! We'll look to get out an updated version of the Muzei API with this fix. As a workaround, you can override this method yourself and construct the PendingIntent with the flag rather than calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Muzei plugins that target API 31 and when run on Android 12.0+ cannot view artwork information, instead returning an
IllegalArgumentExceptiondescribed hereAn API level check is included to maintain compatability with Android versions lower than M